search

metal3-io / project-infra

Metal3 testing infrastructure configuration
https://prow.apps.test.metal3.io
Apache License 2.0
17 stars 20 forks source link

Pin basic-checks image, and add workflow for building it #865

Closed tuminoid closed 1 month ago

tuminoid commented 1 month ago

Pin basic-checks golang base image to have a changelog of the builds and changes, along with workflow to build it, so we get rid of locally built and pushed images.

Fixes: #864

tuminoid commented 1 month ago

/cc @mquhuy @kashifest

tuminoid commented 1 month ago

/hold for @mquhuy's review

mquhuy commented 1 month ago

LGTM

tuminoid commented 1 month ago

/unhold /override metal3-ubuntu-e2e-integration-test-main /cc @kashifest

metal3-io-bot commented 1 month ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/project-infra/pull/865#issuecomment-2382362641): >/unhold >/override metal3-ubuntu-e2e-integration-test-main >/cc @kashifest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/project-infra/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 1 month ago

/unhold /override metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 1 month ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/project-infra/pull/865#issuecomment-2382736162): >/unhold >/override metal3-ubuntu-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.