search

metal3-io / project-infra

Metal3 testing infrastructure configuration
https://prow.apps.test.metal3.io
Apache License 2.0
17 stars 20 forks source link

Split prow config #891

Closed lentzi90 closed 2 weeks ago

lentzi90 commented 3 weeks ago

This moves all prow config to one folder outside of the kustomization and splits the jobs into multiple files. Kustomize cannot automatically create configmaps from all files in a folder recursively so I think it makes more sense to handle the config separately. Then we can also keep them in a place that is perhaps easier to find. This also paves the way for eventually separating out the secrets from the kustomization so that we can have a job for applying changes across all the manifests (not just the config).

The jobs are now in one file per repo. We can change this to one folder per repo or something else if we want.

Fixes: #713

lentzi90 commented 3 weeks ago

@lentzi90: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command check-prow-config 3d2c8c9 link true /test check-prow-config

Full PR test history. Your PR dashboard.

This fails because I have not updated the in-cluster config yet. It is trying to look for the config in its old place.

lentzi90 commented 3 weeks ago

Thanks for the suggestion @tuminoid ! It is definitely doable if I understood you correctly, and I think I have a working solution now. What do you think?

tuminoid commented 3 weeks ago

Thanks for the suggestion @tuminoid ! It is definitely doable if I understood you correctly, and I think I have a working solution now. What do you think?

I need to take better look, but yes, that was what I was suggesting. Thanks!

Rozzii commented 2 weeks ago

/remove lgtm

Rozzii commented 2 weeks ago

/lgtm cancel

Rozzii commented 2 weeks ago

/remove-lgtm

Rozzii commented 2 weeks ago

/override check-prow-config

metal3-io-bot commented 2 weeks ago

@Rozzii: Overrode contexts on behalf of Rozzii: check-prow-config

In response to [this](https://github.com/metal3-io/project-infra/pull/891#issuecomment-2461708109): >/override check-prow-config Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lentzi90 commented 2 weeks ago

/hold

lentzi90 commented 2 weeks ago

(Putting hold so I can apply the changes and check the test before it merges)

lentzi90 commented 2 weeks ago

/test check-prow-config

lentzi90 commented 2 weeks ago

/hold cancel The test passes now that I have applied the change

lentzi90 commented 2 weeks ago

/override metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 2 weeks ago

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/project-infra/pull/891#issuecomment-2461831011): >/override metal3-ubuntu-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/project-infra/blob/main/OWNERS)~~ [tuminoid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 2 weeks ago

@lentzi90: Updated the following 4 configmaps:

In response to [this](https://github.com/metal3-io/project-infra/pull/891): >This moves all prow config to one folder outside of the kustomization and splits the jobs into multiple files. >Kustomize cannot automatically create configmaps from all files in a folder recursively so I think it makes more sense to handle the config separately. Then we can also keep them in a place that is perhaps easier to find. >This also paves the way for eventually separating out the secrets from the kustomization so that we can have a job for applying changes across all the manifests (not just the config). > >The jobs are now in one file per repo. We can change this to one folder per repo or something else if we want. > >Fixes: #713 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.