search

metal3d / katenary

Convert docker and podamn compose to a configurable helm chart
MIT License
154 stars 11 forks source link

Wrong syntax with TCP healthcheck #30

Closed adrian-salas closed 1 year ago

adrian-salas commented 2 years ago

Hello,

After using the following label: katenary.io/healthcheck: tcp://localhost:3306

The generated output is the following:

livenessProbe:
  tcp:
    port: 3306
            ...

However the syntax is: tcpSocket (https://kubernetes.io/fr/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#d%C3%A9finir-une-tcp-liveness-probe)

fkukus commented 2 years ago

Hello, I reproduce the issue and confirm the fix is correct. Thanks!