search

metalbear-co / mirrord-vscode

Connect your local process and your cloud environment, and run local code in cloud conditions.
https://mirrord.dev
MIT License
8 stars 10 forks source link

Select mirrord.json as default config choice #130

Open emanuelef opened 5 months ago

emanuelef commented 5 months ago

Now it there are multiple files in .mirrord folder named *mirrord.json it's not clear which one will be used. https://github.com/metalbear-co/mirrord-vscode/blob/f8acc3b9d68a06cf701091585afac61623ab3afa/src/config.ts#L205 In my case I have multiple files in that folder one named __mirrord.json, that was being used while I was expecting mirrord.json to be used. I guess one option is to choose mirrord.json file over others containing mirrord, or document this somewhere.

aviramha commented 5 months ago

I think we should restrict the regex to mirrord.{json/yaml/toml} for default config

emanuelef commented 5 months ago

I guess the only risk there is for people who don't have mirrord.{json/yaml/toml} but something like *mirrord, so for them it will stop working when upgrading.

Razz4780 commented 5 months ago

The plugin sorts default config candidates using String.localeCompare and always picks the first one from the list. We should document it somewhere