search

metalbear-co / mirrord-vscode

Connect your local process and your cloud environment, and run local code in cloud conditions.
https://mirrord.dev
MIT License
8 stars 10 forks source link

nvm use - doesn't get SIP patched(?) #34

Closed aviramha closed 1 year ago

aviramha commented 1 year ago

macOS similar to https://github.com/metalbear-co/mirrord-vscode/issues/26 launch.json 

{
      "command": "nvm use; npm run build:prod",
      "name": "Run npm start",
      "request": "launch",
      "type": "node-terminal"
 }
t4lz commented 1 year ago

Yup, didn't handle a multi-command line, so we would only patch nvm in with this command line. I guess we need some more sophisticated logic that detects which word out of multiple words in multiple;-seperated commands is the relevant node executable.

aviramha commented 1 year ago

Yup, didn't handle a multi-command line, so we would only patch nvm in with this command line. I guess we need some more sophisticated logic that detects which word out of multiple words in multiple;-seperated commands is the relevant node executable.

what about just wrapping it all in a shell so we patch the shell, then on exec/fork we already handle it from there?

t4lz commented 1 year ago

Yup, didn't handle a multi-command line, so we would only patch nvm in with this command line. I guess we need some more sophisticated logic that detects which word out of multiple words in multiple;-seperated commands is the relevant node executable.

what about just wrapping it all in a shell so we patch the shell, then on exec/fork we already handle it from there?

Smart!