metalcorebear / NRCLex

An affect generator based on TextBlob and the NRC affect lexicon. Note that lexicon license is for research purposes only.
MIT License
63 stars 36 forks source link

a few quality of life improvements #8

Closed Jivanni closed 3 years ago

Jivanni commented 3 years ago

Hi metalcorebear, I have made some changes to your lovely library after using it in some of my projects:

If you this those changes make sense, please feel free to merge them into your project.

jivanni

riyadhctg commented 2 years ago

I actually think changes in this PR breaks the package installation (i.e. pip install git+......)

Also, I think we don't need to install collections and json as separate package, at least for newer python version

metalcorebear commented 2 years ago

You could be right. The code is pretty messy and not well documented (I didn't expect it to become a popular project). I honestly haven't looked at the repo in the last year, but I know it needs some improvements. I'm hoping to find time in August to fix it up, but if you want to make the necessary improvements, please feel free to do so.