xsd-makepkg generated code can not unmarshal element based on xsdt types

[lobatt]

Example: http://www.atsc.org/XMLSchemas/pmcp/2007/3.1/pmcp31.xsd

<xsd:complexType name="TextType">
    <xsd:annotation>
        <xsd:documentation>One string of a Multiple String Structure of PSIP (A/65B 6.10)</xsd:documentation>
    </xsd:annotation>
    <xsd:simpleContent>
        <xsd:extension base="xsd:string">
            <xsd:attribute name="lang" type="languageType" use="required"/>
            <xsd:attribute name="action" type="actionType" use="optional"/>
            <xsd:attribute name="error" type="errorType" use="optional"/>
        </xsd:extension>
    </xsd:simpleContent>
</xsd:complexType>

The schema above will generate:

type TBxfText struct {
    XsdtString 

   XsdGoPkgHasAtts_ActionErrorGroup

   XsdGoPkgHasAttr_Lang_PmcpTlanguageType_

   XsdGoPkgHasAttr_Size_XsdtPositiveInteger_

   XsdGoPkgHasAttr_Type_XsdtString_
}

There are 2 issues here:

1. XsdtString should actually be xsdt.String
2. since https://github.com/metaleap/go-xsd/blob/master/types/xsdtypes.go have no xml tags specified, no value will be able to be unmashal into this embedded field.

Possible solution:

diff --git a/elemmakepkg.go b/elemmakepkg.go
index e81d961..2ac785b 100644
--- a/elemmakepkg.go
+++ b/elemmakepkg.go
@@ -281,7 +281,11 @@ func (me *ComplexType) makePkg(bag *PkgBag) {
                }
        }
        if ctBaseType = bag.resolveQnameRef(ctBaseType, "T", nil); len(ctBaseType) > 0 {
-               td.addEmbed(nil, bag.safeName(ctBaseType))
+               if strings.HasPrefix(ctBaseType, "xsdt.") {
+                       td.addEmbed(nil, idPrefix+"HasCdata")
+               } else {
+                       td.addEmbed(nil, bag.safeName(ctBaseType))
+               }
        } else if ctValueType = bag.resolveQnameRef(ctValueType, "T", nil); len(ctValueType) > 0 {
                bag.simpleContentValueTypes[typeSafeName] = ctValueType
                td.addField(nil, idPrefix+"Value", ctValueType, ",chardata")

Thoughts?

[purohit]

I had the same problem with (1. XsdtString should actually be xsdt.String). I changed them all by hand.

[grmartin]

I ran in to this this morning as well. Thanks for the assist.

[thiloplanz]

Is there a reason this patch is not being merged? Are there situations where it does not work?

I just ran into the same problem today (generated code would not compile because of XsdtString) and the fix provided by @lobatt solved that.

[lobatt]

I guess it was mostly because of this repo was abandoned by the author. lol

[taiyangc]

@lobatt Do you think it's worth the effort to put up a PR for the patch? It would be super helpful than each of us doing our own forks. Owner seems to be around lately :) Thanks!

[metaleap]

Yeah I'm around for pull-requests!