search

metalfiiish / ts-gw2-verifyBot

A python bot that will sit in a Teamspeak3 channel and take commands. It's main purpose was to verify server players for Guild Wars 2 and automatically authenticate and give them the proper Group for permissions to speak/etc in Teamspeak.
MIT License
7 stars 7 forks source link

Remove Account Name from registration #7

Open ogrady opened 5 years ago

ogrady commented 5 years ago

Users currently need to give the bot their Account Name and their API-Key upon registration. Shockingly, a good lot of people don't know their own account name or fail to write it down correctly, resulting in staff having to guide users through the registration process in excruciating detail only to find out that user TCWarrior.5463 is actually TCWarrior.5436.

Since having acquired an API-Key gives you easy access to the account name through websites like https://mygw2.wvwintel.com/, having to enter the account name doesn't serve as additional security feature to prevent stolen keys from being used in a malicious way either.

I therefore suggest dropping the prompt for the account name altogether to improve usability for users and reduce support time for staff.

metalfiiish commented 5 years ago

It's not the first time and the debate can go both ways, in the end if this is the desire of the user base then so be it.

I removed the part that requires it to match, need to do some thinking of how to reorder the regex and limit statement in command handler so the final piece will take me some time to test with, which I don't have right this minute.

metalfiiish commented 5 years ago

Made some final changes, spun up a test server and it seems to work for me. Do me a solid and test and let me know if things blow up. Havn't touched this guy in ages :)

ogrady commented 5 years ago

Thanks for addressing this so quickly! I will do some testing asap and get back at you.

ogrady commented 5 years ago

I have tested around a bit and there is a small error in the RegEx you are using. I have opened a pr which fixes this issue. https://github.com/metalfiiish/ts-gw2-verifyBot/pull/8

Also, several messages in bot_messages.py still contain a prompt for the account name (and some typos). ~Since I need the bot to work in German, I might attempt a localisation feature and fix the English localisation and contribute it as another pr, if you'd like.~ Update: I have finished the localisation feature. I accidentally put it in the same pull request as the regex fix. You can of course cherry pick only the fix, if you wish.

metalfiiish commented 5 years ago

It's fine, it looks good. You seem to be an avid user so if you face anymore problems let me know, I really only have my debug server now. Not in close touch with the TC team that I made it for anymore to test on theirs so any insight is helpful. Leaving open for now so we can monitor for a bit.

ogrady commented 5 years ago

Fine with me. It might take a while before I can test it thoroughly with multiple users, since we are right in the process of migrating our community to another TS3 server. I can get back at you when the bot has been up and running for a while under load.