search

metalmatze / slo-libsonnet

Generate Prometheus alerting & recording rules and Grafana dashboards for your SLOs.
https://promtools.dev
Apache License 2.0
121 stars 19 forks source link

Add gRPC SLOs #16

Closed kakkoyun closed 5 years ago

kakkoyun commented 5 years ago

Attempt to add gRPC SLOs #15

metalmatze commented 5 years ago

Once we make use of this in the kube-thanos project, I'm happy to merge this as well. Or do you think we should merge already?

kakkoyun commented 5 years ago

Let's merge it after we experience the usage in kube-thanos.

kakkoyun commented 5 years ago

@metalmatze I'm closing this one, it needs a lot of reconsideration after recent changes,

metalmatze commented 5 years ago

Thanks for working on it anyway! We should review the recent additions to whether we can make use of those for gRPC too (which they should be)