metalmatze / slo-libsonnet

Generate Prometheus alerting & recording rules and Grafana dashboards for your SLOs.
https://promtools.dev
Apache License 2.0
121 stars 19 forks source link

Improve errors and errorburn closer to errorlatencyburn function #40

Closed metalmatze closed 4 years ago

metalmatze commented 4 years ago

In another PR I propose the merge the errorlatencyburn function which is basically extracted from the learnings I had during creating multi error burn rate alerts for the APIServer.

Taking these improvements back to errors and errorburn is a logical next step. Once we discussed these here, we can also improve latencyburn.

I think this makes a couple of things a lot easier. :)

/cc @krasi-georgiev @brancz @aditya-konarde @kakkoyun @squat