metalpriest / pysimplesoap

Automatically exported from code.google.com/p/pysimplesoap
0 stars 0 forks source link

Have the SoapFault include a dictionary containing the error details #156

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
We have a use case that's not currently supported. In our services we have more 
complex fault messages that include error details in addition to just fault 
codes and fault strings. The current way of raising these errors to the client 
is by using the SoapFault class which only exposes a code and a string.

In the attached file, there's an example of what a fault message like this 
looks like. There's also a snippet from a WSDL where such a message gets 
defined.

We want to do something closer to how successful output is handled, where a 
dictionary containing the result payload is returned instead. Are there any 
plans to add this? Can we put in a PR for something like this? Or did you have 
some thoughts on the specifics of how you would want this implemented?

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please attach the related WSDL (if any), a small code fragment to reproduce
and provide any additional information below.

Original issue reported on code.google.com by anuragj...@gmail.com on 17 Sep 2014 at 2:59

Attachments:

GoogleCodeExporter commented 8 years ago
I had no time to work on this right now, but feel free to go ahead and propose 
a PR

The current code that parses the WSDL could be reused for this.
I think that refactoring it out (to parse general xml schemas) could be useful 
to marshal/unmarshal non wsdl related ones.

Original comment by reingart@gmail.com on 17 Sep 2014 at 6:01

GoogleCodeExporter commented 8 years ago
I've submitted a pull request to address this, for SOAP 1.1 services.  I would 
appreciate if anyone could review the code and verify that this works on their 
end.

https://github.com/pysimplesoap/pysimplesoap/pull/29

Original comment by d.li...@gmail.com on 3 Dec 2014 at 10:08