fix(nunjucks): patch nunjucks views path

metalsmith / layouts

A metalsmith plugin for layouts

MIT License

116 stars 49 forks source link

fix(nunjucks): patch nunjucks views path #124

Closed tungptvn closed 7 years ago

tungptvn commented 7 years ago

 "metalsmith-layouts": {
        "engine": "nunjucks",
        "directory": "./layouts",
        "partials": "./layouts/partials",
        "nunjucks": {
          "configure": ["./layouts", {
            "autoescape": true
          }]
        },
      },

ismay commented 7 years ago

Thanks for the pr @tungptvn! Could you explain what this PR addresses?

ismay commented 7 years ago

@tungptvn I think that in order to be merged there are still some things that need to be adressed:

A test for the fixed bug
An explanation in the readme of when users'll need to do this, and what purpose it serves exactly
The new code block needs whitespace around it

Also, I haven't heard from you on what this fixes exactly, so I'll close this PR for now. If you're willing to address these issues let me know and we can take a closer look.