metalsmith / layouts

A metalsmith plugin for layouts
MIT License
116 stars 49 forks source link

Cannot include a handlebars layout with a partial #142

Closed aaronibrahim closed 6 years ago

aaronibrahim commented 6 years ago

I've tried every which way to have a handlebars layout include a handlebars partial and it hasn't worked.

Here are my setups demonstrating the problem I'm having:

Thank you in advance for your assistance, and please let me know if there is more code I can put up to demonstrate or troubleshoot the problem.

ismay commented 6 years ago

Hi @aaronibrahim, partials are no longer automatically registered by this plugin, so you'll need to use metalsmith-register-partials instead. See the changelog: https://github.com/ismay/metalsmith-layouts/blob/master/CHANGELOG.md#200---january-10-2018

Then it should work.

aaronibrahim commented 6 years ago

A note to anyone who might come across this thread, metalsmith-register-partials wasn't updated to address a breaking change in a later metalsmith release, so @timdp released metalsmith-discover-partials and metalsmith-discover-helpers and they worked for me.

ismay commented 6 years ago

@aaronibrahim Thanks for mentioning those plugins! I didn't know that register-partials no longer worked. I'll add the new plugins to the readme.

glen-84 commented 5 years ago

@ismay Could you also update the GitHub release description?

ismay commented 5 years ago

@glen-84 I might address that later. For now you can refer to the changelog.