Closed SethFalco closed 2 years ago
Thx @SethFalco,
I have 1 main poinrt before this can be merged:
npm info <pkg>@* engines.node
. Unfortunately the latest Node 8 compatible version for multimatch is 4.0.0, so that needs to be re-downgraded. For devDependecies the ones used in CI npm test
need to be compatible with the environments they are used in. That means jest@25.5.4
and possibly others. Others can be upgraded to latest.Stackoverflow link can be https
.
I don't really agree with the ESlint rule but I don't mind following it.
Sure, I've added the following to the package.json
also just to kind of document that requirement.
I'm not sure if npm uses it, but I know yarn would automatically check against the engines when installing dependencies.
"engines": {
"node": ">=8"
},
engine.node
field of dependencies.http
links with https
.Just noting it since it's changed from the original PR summary:
Reduces vulnerabilities from 42 moderate severity vulnerabilities
to 19 vulnerabilities (16 moderate, 3 critical)
The build fails because of the test task running with Node 6. If we're only supporting Node >= 8, I assume we can remove that and rerun this?
@SethFalco Correct, I'm in the process of upgrading the plugin repo's to a common setup and that will include the travis.yml currently already available at https://github.com/metalsmith/excerpts/blob/master/.travis.yml
.github/ISSUE_TEMPLATE.md
README.md
lib/index.js
package.json
multimatch
which I only updated to 5.0.0. (Latest is 6.0.0)42 moderate severity vulnerabilities
to5 moderate severity vulnerabilities
Linting and tests all pass after these changes.