metalsmith / layouts

A metalsmith plugin for layouts
MIT License
116 stars 49 forks source link

Update dependencies and health files and fix linter problems #177

Closed SethFalco closed 2 years ago

SethFalco commented 2 years ago

.github/ISSUE_TEMPLATE.md

README.md

lib/index.js

package.json


Linting and tests all pass after these changes.

webketje commented 2 years ago

Thx @SethFalco,

I have 1 main poinrt before this can be merged:

Stackoverflow link can be https. I don't really agree with the ESlint rule but I don't mind following it.

SethFalco commented 2 years ago

Sure, I've added the following to the package.json also just to kind of document that requirement. I'm not sure if npm uses it, but I know yarn would automatically check against the engines when installing dependencies.

"engines": {
  "node": ">=8"
},

Just noting it since it's changed from the original PR summary: Reduces vulnerabilities from 42 moderate severity vulnerabilities to 19 vulnerabilities (16 moderate, 3 critical)

SethFalco commented 2 years ago

The build fails because of the test task running with Node 6. If we're only supporting Node >= 8, I assume we can remove that and rerun this?

image

webketje commented 2 years ago

@SethFalco Correct, I'm in the process of upgrading the plugin repo's to a common setup and that will include the travis.yml currently already available at https://github.com/metalsmith/excerpts/blob/master/.travis.yml