search

metalsmith / permalinks

A Metalsmith plugin for permalinks.
MIT License
62 stars 67 forks source link

Switch to xo + prettier. #104

Closed XhmikosR closed 4 years ago

XhmikosR commented 5 years ago

This was the "easiest" solution which I believe makes things much stricter, but ultimately it's the maintainers' choice.

Don't judge the CI result because lint has the --fix switch. After #99 there should be 3-4 errors left which should be easy to fix or ignore.

Note that this patch currently uses an older xo version for Node.js 6 compatibility.

woodyrew commented 5 years ago

Could you fix the CI build issues before merge.

XhmikosR commented 5 years ago

Just restart it, it's unrelated to this PR

XhmikosR commented 5 years ago

Windows will be fixed by #105

XhmikosR commented 5 years ago

@Ajedi32 Rebased

XhmikosR commented 4 years ago

@woodyrew @Ajedi32 can you please review the remaining PRs and release a patch version? The fixes so far are quite important.

Ajedi32 commented 4 years ago

Thanks for the reminder. I don't believe I have the necessary permissions to publish new releases to NPM, but I'll get these PRs reviewed and merged as soon as I can.

XhmikosR commented 4 years ago

@woodyrew @Ajedi32 friendly ping. Can you move ahead with the remaining PRs and release a new minor/patch version? There have been quite a few improvements.

Ajedi32 commented 4 years ago

Sorry for the delay. Looks good to me.