search

metalsmith / permalinks

A Metalsmith plugin for permalinks.
MIT License
62 stars 67 forks source link

Windows fix #105

Closed XhmikosR closed 5 years ago

XhmikosR commented 5 years ago

This seem to fix the test, but I'm not 100% sure it's the proper fix.

I'm not sure the dupes are proper with this patch.

We need some of my other PRs like #99, #100 and #101 for Windows testing. I'll rebase this when the other PRs are sorted.

Fixes #67, fixes #93

With this patch, we get no more backslashes on https://github.com/nodejs/nodejs.org/runs/257685124

Ajedi32 commented 5 years ago

Now that #99 is merged I believe this should be ready for review?

XhmikosR commented 5 years ago

@Ajedi32 yeah but I'm still not sure the cache and dupes is working fine on Windows.

XhmikosR commented 5 years ago

@woodyrew this needs review. What I'm not sure if if the dupes cache is borked now on Windows.

I think we should probably streamline this. Always use forward slashes except when we deal with the filesystem.

That being said this does fix the issue for me.

XhmikosR commented 5 years ago

@woodyrew @Ajedi32 friendly ping. I'm still not sure if the patch is 100% regarding the dupes cache, but it does fix the issue with backslashes on Windows.