search

metalsmith / permalinks

A Metalsmith plugin for permalinks.
MIT License
62 stars 67 forks source link

Move segment-boneyard/substitute to the repo. #111

Closed XhmikosR closed 4 years ago

XhmikosR commented 5 years ago

The package isn't published on npm, and it's small anyway.

Closes #109

If anyone could get the package published, we could drop this patch.

XhmikosR commented 5 years ago

@Ajedi32 I didn't touch the code in the file, I just moved it here.

Further changes could be made, but maybe in a separate PR/release. Because with the patches merged so far, I think you should release a minor or patch release.

XhmikosR commented 5 years ago

Actually @Ajedi32 before the new minor/patch release, let's get these merged:

Ajedi32 commented 4 years ago

@XhmikosR FYI, sorry I never got to these. I'll admit I've not had a lot of time or interest in maintaining this project lately.

Out of curiosity, would you be interested in taking over development if given the opportunity? I don't really have the ability to grant people access to the repository, but I'd be willing to help kick-start the process if you're interested. Your contributions so far have been great (at least the ones I've gotten around to reviewing) and it seems like you have a lot more motivation to work on this than I do.

XhmikosR commented 4 years ago

No worries, I guess it's the beauty and the curse of OSS :/

Sorry, I don't have the time either. I just wanted a new release to fix the Windows issues which affects us on the nodejs.org repo. And back then, I decided to help improve the project a bit, that's all.