search

metamath / metamath-knife

Metamath-knife can rapidly verify Metamath proofs, providing strong confidence that the proofs are correct.
Apache License 2.0
25 stars 10 forks source link

API Change #34

Closed tirix closed 2 years ago

tirix commented 2 years ago

This Grammar API lists the possible type codes.

Since a TypeCode is in fact a u32, we can simply return a boxed slice, rather than a boxed slice of references. This also aligns with the recent change in the parse_formula API.

digama0 commented 2 years ago

We can just return a reference to a slice, which allows the user to avoid the allocation overhead if they don't need it.

david-a-wheeler commented 2 years ago

Reference sounds much better. @tirix agree?

tirix commented 2 years ago

Reference sounds much better. @tirix agree?

Indeed, this is changed in my last commit!