search

metamath / metamath-website-scripts

Scripts to set up the metamath website(s) so they're under version control, can be reviewed, and can be rerun. The scripts download the seed files from metamath-website-seed, databases from set.mm, etc.
MIT License
2 stars 3 forks source link

Rewrite regenerate #12

Closed david-a-wheeler closed 10 months ago

benjub commented 1 year ago

Version control allows you to retrieve older versions, so no need to keep the whole old script commented out, you can simply remove it.

david-a-wheeler commented 1 year ago

Version control allows you to retrieve older versions, so no need to keep the whole old script commented out, you can simply remove it.

Sure, but I'm trying to re-implement the functionality we care about AND throw away the rest. I'm using the old script commented-out to help me identify what needs doing.

I don't want to remove the old script yet, because that's the script we run daily. This way I can merge this branch without ruining anything.

benjub commented 1 year ago

Version control allows you to retrieve older versions, so no need to keep the whole old script commented out, you can simply remove it.

Sure, but I'm trying to re-implement the functionality we care about AND throw away the rest. I'm using the old script commented-out to help me identify what needs doing.

I don't want to remove the old script yet, because that's the script we run daily. This way I can merge this branch without ruining anything.

Ok, as your prefer, and it'll be deleted later. In any case, this should not delay the merge.

jkingdon commented 10 months ago

Is this pull request obsolete now that #16 has been merged?

I suspect so, in which case it can be closed.

digama0 commented 10 months ago

The contents of this PR were merged into #16 in https://github.com/metamath/metamath-website-scripts/pull/16/commits/3edd32b1693af8c4874be1188b5b7ee4152cec77.