metan-ucw / runltp-ng

Minimalistic LTP testrunner
11 stars 16 forks source link

better taint flag handling #40

Open metan-ucw opened 3 years ago

metan-ucw commented 3 years ago

Currently we check kernel taint flags after a failed test and reboot system if any are set.

This is broken for several reasons:

So all in all we should check for taint flags after each test and attempt reboot the system if any of the serious flags are set I guess that we want to reboot at least on R, M, B, D, W, L flags.

Also we should check the kernel taint flags before the testrun and the runltp-ng should exit if any of the serious flags are set prior the start of the testsuite.

Another part of the problem are tests that may trigger taint flags "module was force unloaded" may be triggered by rmmod tests, so we probably need .sets_taint_flags in tst_test structure in testcases which would get parsed into the test metadata and the testrunner will make use of that information, e.g. schedule such test to be executed as a last one.

pevik commented 3 years ago

Besides these improvements IMHO it'd be handy to add environment variable to completely disable reboot for environments where it's not wanted.