metanorma / asciidoctor-rfc

AsciiRFC: an AsciiDoc/asciidoctor backend to produce RFC XML v3 (RFC 7991) and v2 (RFC 7749)
BSD 2-Clause "Simplified" License
15 stars 7 forks source link

Migrate to GH Actions #107

Closed CAMOBAP closed 4 years ago

CAMOBAP commented 5 years ago
ronaldtse commented 5 years ago

@CAMOBAP795 failing on macOS and Windows.

CAMOBAP commented 4 years ago

Two problems here:

  1. Some incompatibility issues for Ruby 2.6 on Windows, I noticed if https://github.com/riboseinc/asciidoctor-bibliography.git has been removed from Gemfile, it works IDK why, so I propose to remove it from Gemfile because we don't use it

  2. Issue on windows

    C:\Users\IEUser\asciidoctor-rfc>ruby bin/asciidoctor-rfc2 some.adoc 
    spec/examples/hoffmanv2.xml.adocTraceback (most recent call last):
        8: from bin/asciidoctor-rfc2:4:in `<main>'
        7: from C:/tools/ruby25/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:39:in `require'
        6: from C:/tools/ruby25/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:135:in `rescue in require'
        5: from C:/tools/ruby25/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:135:in `require'
        4: from C:/tools/ruby25/lib/ruby/gems/2.5.0/gems/metanorma-ietf-1.0.6/lib/asciidoctor/rfc/v2/converter.rb:3:in `<top (required)>'
        3: from C:/tools/ruby25/lib/ruby/gems/2.5.0/gems/metanorma-ietf-1.0.6/lib/asciidoctor/rfc/v2/converter.rb:3:in `require_relative'
        2: from C:/tools/ruby25/lib/ruby/gems/2.5.0/gems/metanorma-ietf-1.0.6/lib/asciidoctor/rfc/common/base.rb:10:in `<top (required)>'
        1: from C:/tools/ruby25/lib/ruby/gems/2.5.0/gems/metanorma-ietf-1.0.6/lib/asciidoctor/rfc/common/base.rb:11:in `<module:Asciidoctor>'C:/tools/ruby25/lib/ruby/gems/2.5.0/gems/asciidoctor-1.5.8/lib/asciidoctor.rb:1616:in `const_missing': uninitialized constant Asciidoctor::Rfc (NameError)
CAMOBAP commented 4 years ago

Separate issue reported for failed tests on windows https://github.com/metanorma/asciidoctor-rfc/issues/108

ronaldtse commented 4 years ago

Thanks @CAMOBAP795 !