metanorma / asciidoctor-rfc

AsciiRFC: an AsciiDoc/asciidoctor backend to produce RFC XML v3 (RFC 7991) and v2 (RFC 7749)
BSD 2-Clause "Simplified" License
15 stars 7 forks source link

CR before literal/sourcecode #95

Closed opoudjis closed 6 years ago

opoudjis commented 6 years ago

https://datatracker.ietf.org/doc/conflict-review-ribose-asciirfc/ballot/

Adam Roach No Objection Comment (2018-03-30) I think the answer is correct.

On a quick skim, I note that the document itself -- presumably produced by the toolchain it describes -- appears to have all leading spaces stripped from artwork and code, resulting in varying degrees of damage to readability. I would hope that the popularization of this toolchain does not lead to documents with similar defects showing up for approval in the IESG stream, and would strongly recommend that the authors debug this aspect of the toolchain prior to publication of this document.

ronaldtse commented 6 years ago

Thanks for posting this @opoudjis .

ronaldtse commented 6 years ago

@opoudjis I just want to confirm that the issue is about line length exceeding limits (we have some https links that are beyond 72 chars) or is it because of stripping leading spaces?

opoudjis commented 6 years ago

It's the latter

ronaldtse commented 6 years ago

Cool, thanks.

opoudjis commented 6 years ago

I'm making artwork be wrapped in CDATA, which is what they do; but this looks to be an artefact of the folding script. Adjusting both.