search

metanorma / ci

Build scripts for Metanorma, works with continuous integration
3 stars 2 forks source link

Use deploy-pages for our samples repositories #146

Closed CAMOBAP closed 4 months ago

CAMOBAP commented 5 months ago

Origin: https://github.com/actions-mn/build-and-publish/issues/4#issuecomment-1931309962

Use https://github.com/actions-mn/deploy-pages for all our samples repositories

CAMOBAP commented 4 months ago

Looks like this approach will not work(

/usr/bin/git push --force ***github.com/metanorma/mn-samples-iso.git github-pages-deploy-action/6krd58h88:gh-pages remote: error: Trace: fb1f108bbeabd69a39dcae77aace7751c3f070296eda05826523f605c24007d6
remote: error: See https://gh.io/lfs for more information.
remote: error: File artifact.tar is 183.21 MB; this exceeds GitHub's file size limit of 100.00 MB
remote: error: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com./
To https://github.com/metanorma/mn-samples-iso.git ! [remote rejected] github-pages-deploy-action/6krd58h88 -> gh-pages (pre-receive hook declined)

https://github.com/metanorma/mn-samples-iso/actions/runs/7864811669/job/21457108730

Most of our repo has artifacts more then 100Mb

Looking for workaround right now, it not found anything soon, will revert the change

ronaldtse commented 4 months ago

Instead of git push, we upload the artifact using GHA upload-artifact?

CAMOBAP commented 4 months ago

There are no issues with uploading artifacts but then the content of it gets committed to the gh-pages branch, I trying to understand why it's trying to commit the whole artifact without decompression

ronaldtse commented 4 months ago

Interesting. Maybe on the upload artifact step, we’re not supposed to archive the files. That causes GitHub to think that the file is a single file which leads to the LFS limitation of 100MB.

I remember that on GH that the upload artifact step directly counts towards the “size count” of the account, so the drawback is that GitHub will charge / count the size according to the raw size, but the benefit is it allows uploading those files individually.

CAMOBAP commented 4 months ago

Update. After updating actions versions to new one (to avoid the Node warning) now it fails with

Error: Unable to download artifact(s): Artifact not found for name: github-pages Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact. For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

Investigation continued...

CAMOBAP commented 4 months ago

It actually commits artifacts.tar https://github.com/metanorma/mn-samples-iec/tree/gh-pages for some reason, investigation in pgoress

CAMOBAP commented 4 months ago

Because changes in vaniala actions/upload-pages-artifact it now works such way i.e. upload archive.tar and not path to _site

Possible fix on test https://github.com/metanorma/mn-samples-iso/pull/90

UPD. testin on main https://github.com/metanorma/mn-samples-iso/actions/runs/7872033494

CAMOBAP commented 4 months ago

It works waiting for other repos to pass