search

metanorma / metanorma-cli

CLI (Command Line Interface) for Metanorma
BSD 2-Clause "Simplified" License
5 stars 5 forks source link

1.8.2 Release failure #312

Closed CAMOBAP closed 1 year ago

CAMOBAP commented 1 year ago

Observed issues:

  1. "Invalid MathML" https://github.com/metanorma/packed-mn/actions/runs/6008410758 Affected flavors: bipm, itu, jcgm Relevant issue: https://github.com/plurimath/plurimath/issues/183

  2. And "dig': String does not have #dig method (TypeError)" https://github.com/metanorma/metanorma-cli/actions/runs/6008320853/job/16298011674 Affected flavors:ietf` (rfc template)

P.S. Those issues was discovered in 1.8.2-pre release https://github.com/metanorma/packed-mn/actions/runs/5998894855/job/16268475936 but wasn't fixed for some reason...

P.S. This is "umbrella" ticket, once MathMl issue will be fixed we can restart release on packed-mn, metnorma-docker no new release of metanorma-cli will be need

cc @ronaldtse @opoudjis

CAMOBAP commented 1 year ago

isodoc@2.6.2 released

packend-mn@1.8.2 restarted for ubuntu

cc @ronaldtse @opoudjis

CAMOBAP commented 1 year ago

"Invalid MathML:" still appears on: bipm,itu, jcgm. + ogc also

The packed-mn was restarted and I can confirm that picked up latest:

@opoudjis maybe I missed something?

ronaldtse commented 1 year ago

@suleman-uzair can you please incorporate these MathML validation tests into Plurimath ASAP? They are blocking release. Thanks.

opoudjis commented 1 year ago

So... lemme get this straight:

https://github.com/metanorma/metanorma-cli/actions/runs/6091927992/job/16533805828 : now metanorma-cli goes through all the samples ever, and takes 4 hrs. On top of whatever docker is doing.

There is a reason I am constantly angry at this project. This is insane.

Pending issues now:

  1. template-ietf: https://github.com/metanorma/metanorma-ietf/issues/188, already addressed, planning to do hotfix of standoc
  2. sample-bsi: missing images/coverpage.png: https://github.com/metanorma/mn-samples-bsi/issues/321
  3. sample-nist claim that a URI is malformed (not seeing how): https://github.com/metanorma/mn-samples-nist/issues/98

We are going to introduce a fourth issue: I am going to review @suleman-uzair ’s latest Plurimath update, and switch html2doc across to using Plurimath. I am going to want to test it on all repos, to ensure we do not have even more disasters.

CAMOBAP commented 1 year ago

https://github.com/metanorma/metanorma-cli/actions/runs/6091927992/job/16533805828 : now metanorma-cli goes through all the samples ever, and takes 4 hrs. On top of whatever docker is doing.

But what is the alternative?

Running tests locally cannot be an alternative because we must support macOS and Windows too

I suppose it better to spot issues here on metanorma-cli and spend this 4h before each release to not fall into the situation as with 1.8.2 never again, and only if metanorma-cli passed, we will initiate release docker/packend-mn etc.

I can handle releases starting from metanorma-cli and downstream, and leave it up to you how to manage/handle other gems releases and which strategy to use there

template-ietf: https://github.com/metanorma/metanorma-ietf/issues/188, already addressed, planning to do hotfix of standoc

Once it is released, to avoid any other regression for other flavors we have to rerun other flavors too, but for really straight cases we can just rerun failed flavors individually and wait less time

It looks like we discuss the same problem over and over again, from my point of view better to wait 4h and be sure that the same issues will not appear in packed-mn/docker/docker-private (3x time!)

But I'm open to any alternative till ti guarantee that metanorma-cli works proreply

CAMOBAP commented 1 year ago

https://github.com/metanorma/metanorma-cli/issues/312#issuecomment-1708056481 @ronaldtse any thoughts on this

opoudjis commented 1 year ago

I am going to delay the Plurimath testing on Github till next release, and test it locally first, enough has gone wrong already.

opoudjis commented 1 year ago

Standoc and NIST hotfixes release, and sample repos updated.

CAMOBAP commented 1 year ago

https://github.com/metanorma/metanorma-cli/actions/runs/6091927992 - re-run for failed in progress

CAMOBAP commented 1 year ago

Observed issue in CI which doesn't allow release on experimental flavors fail, fixed, and restarted

ronaldtse commented 1 year ago

@CAMOBAP is there still an issue with release? Thanks.

CAMOBAP commented 1 year ago

@CAMOBAP is there still an issue with release? Thanks.

yep( already fixed and restarted again

CAMOBAP commented 1 year ago

https://github.com/metanorma/metanorma-cli/actions/runs/6098559657/job/16584200665 - hunged, I killed it and will restart this particular job soon

CAMOBAP commented 1 year ago

metanorma-cli@1.8.3 released but packed-mn, metanorma-docker job wasn't triggered....

Screenshot 2023-09-07 at 5 22 09 PM

Investigating what happens, right now

P.S. triggered manually:

For some reason metanorma-cli send the sha that is not a version tag i.e. without prefix refs/tags/v

To be updated...

CAMOBAP commented 1 year ago

Fixed in https://github.com/metanorma/ci/commit/39a60ad9fe52d00f3beeb08dbb7e28f93e896b40

CAMOBAP commented 1 year ago

Quick update:

CAMOBAP commented 1 year ago

I'm closing this issue and will continue work in the scope of https://github.com/metanorma/chocolatey-metanorma/issues/76

FYI @opoudjis @ronaldtse

ronaldtse commented 1 year ago

Thank you @CAMOBAP !