metanorma / metanorma-cli

CLI (Command Line Interface) for Metanorma
BSD 2-Clause "Simplified" License
5 stars 5 forks source link

#301 return non-zero exit code on fatal errors #320

Closed CAMOBAP closed 8 months ago

CAMOBAP commented 8 months ago
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a390565) 95.87% compared to head (7d407a8) 95.96%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #320 +/- ## ========================================== + Coverage 95.87% 95.96% +0.08% ========================================== Files 15 15 Lines 703 718 +15 ========================================== + Hits 674 689 +15 Misses 29 29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CAMOBAP commented 8 months ago

Locally I have strange crash, but there is no it on CI

     NoMethodError:
       undefined method `svgmap_rewrite' for Metanorma::Utils:Module
     # ./lib/metanorma/cli/collection.rb:19:in `render'
     # ./lib/metanorma/cli/collection.rb:14:in `render'
     # ./lib/metanorma/cli/command.rb:76:in `collection'
     # ./lib/metanorma/cli.rb:34:in `start'
     # ./spec/acceptance/collection_spec.rb:32:in `block in run_metanorma_collection'
     # ./spec/support/console_helper.rb:8:in `capture_stdout'
     # ./spec/acceptance/collection_spec.rb:32:in `run_metanorma_collection'
     # ./spec/acceptance/collection_spec.rb:6:in `block (3 levels) in <top (required)>'
     # ./spec/acceptance/collection_spec.rb:19:in `block (4 levels) in <top (required)>'
     # ./spec/acceptance/collection_spec.rb:19:in `chdir'
     # ./spec/acceptance/collection_spec.rb:19:in `block (3 levels) in <top (required)>'
     # ./spec/acceptance/collection_spec.rb:17:in `block (2 levels) in <top (required)>'
ronaldtse commented 8 months ago

Maybe this has to do with the recent refactor for the new Vectory gem. Ping @alexeymorozov.

alexeymorozov commented 8 months ago

svgmap_rewrite

Yes, high chance it is connected. Vectory is used now in code and a gemspec. One or all of the following gems need to be updated locally:

opoudjis commented 8 months ago

There shall be a single point of dependency to vectory, html2doc.