search

metanorma / metanorma-docker

Docker container for running the Metanorma toolchain
https://www.metanorma.com
5 stars 3 forks source link

Tag functionality doesn't work anymore #115

Closed CAMOBAP closed 3 years ago

CAMOBAP commented 3 years ago

https://github.com/metanorma/metanorma-docker/runs/3448129073?check_suite_focus=true#step:7:17

cc @ronaldtse

CAMOBAP commented 3 years ago

Looks like it happens after https://github.com/metanorma/metanorma-docker/commit/b584782d75278ed412c62565c11f0f07df03f149

To be continued...

ronaldtse commented 3 years ago

The Makefile has to be updated, but I think the right solution is to revert the removal of squash. The docker build squash option flattens the image completely, but we don’t really want that. Let me do the revert there.

CAMOBAP commented 3 years ago

but I think the right solution is to revert the removal of squash

ok

I think the issue why it fails because we don't do tag before push

@ronaldtse will it be ok, if I will push this tiny fix to make CI green?

ronaldtse commented 3 years ago

Of course! Please proceed.

CAMOBAP commented 3 years ago

Fixed, rest will be addressed with #113