search

metanorma / metanorma-docker

Docker container for running the Metanorma toolchain
https://www.metanorma.com
5 stars 3 forks source link

Docker failing to run #127

Closed opoudjis closed 2 years ago

opoudjis commented 2 years ago

Possibly failing to clone git://github.com/brucemiller/LaTeXML.git

https://github.com/metanorma/metanorma-docker/runs/4773975440?check_suite_focus=true

ronaldtse commented 2 years ago

This is because of https://github.com/metanorma/metanorma-docker/blob/e52afebf465636fc810263da02c4e3f2edf34070/ubuntu.sh#L14

This brucemiller/LaTeXML@9a0e7dc5 commit is no longer around.

ronaldtse commented 2 years ago

@CAMOBAP but do we still need to include LaTeXML? If not we should remove that?

CAMOBAP commented 2 years ago

This is because of

https://github.com/metanorma/metanorma-docker/blob/e52afebf465636fc810263da02c4e3f2edf34070/ubuntu.sh#L14

This brucemiller/LaTeXML@9a0e7dc commit is no longer around.

strange because it is available https://github.com/brucemiller/LaTeXML/commit/9a0e7dc5

CAMOBAP commented 2 years ago

@CAMOBAP but do we still need to include LaTeXML? If not we should remove that?

good question, recently we discussed https://github.com/metanorma/metanorma-cli#external-dependencies and we don't depend on it

fix in the progress

CAMOBAP commented 2 years ago

@opoudjis @ronaldtse

Fixed, should I retag v1.5.6pre?

ronaldtse commented 2 years ago

Yes please, thanks!

CAMOBAP commented 2 years ago

@ronaldtse probably it's not make sense because v1.5.6 passed successfully