metanorma / metanorma-docker

Docker container for running the Metanorma toolchain
https://www.metanorma.com
5 stars 3 forks source link

Push to GitHub Container Registry in addition to Docker Hub #134

Closed ronaldtse closed 2 years ago

CAMOBAP commented 2 years ago

At the moment technically there is no issue to migrate docker/build-and-push action (which is used already in https://github.com/metanorma/metanorma-docker-private/)

I think for troubleshooting it will be nice to have Makefile also, but also will be nice to not maintain both Makefile and docker.yml separately

I just wondering is it possible to keep labels/tags in some config to simplify Makefile

@ronaldtse may be you know some tool which can help with this, or can suggest some docker expect in our team?

ronaldtse commented 2 years ago

I think for troubleshooting it will be nice to have Makefile also, but also will be nice to not maintain both Makefile and docker.yml separately

I agree that the Makefile is too complex -- I wrote the original version and @ribose-jeffreylau improved on it.

I suggest we just get rid of the Makefile for now, and re-build a Makefile after we have a good docker.yml.

ronaldtse commented 2 years ago

In addition, the jobs like #133 take a long time to validate. We should probably use a GHA matrix to expand on the flavors to test the docker container, i.e. build it, and then run the tests of multiple flavors on the built container.

CAMOBAP commented 2 years ago

Waiting for CI

ronaldtse commented 2 years ago

In the latest build (https://github.com/metanorma/metanorma-docker/actions/runs/1995185481), it's still only pushing to docker.io not gchr.io. Notice that on the front page of this repo there is still no listed package:

Screenshot 2022-03-17 at 9 15 46 AM

In order to also push to gchr.io, we also need to tag the containers with a gchr.io ID. I don't think we're doing that now?

CAMOBAP commented 2 years ago

@ronaldtse last push was successful, but I cannot see containers probably because of visibility settings. May I ask you to have a look?

ronaldtse commented 2 years ago

Yes it worked, and permissions now fixed. Thanks @CAMOBAP !

Screenshot 2022-03-18 at 10 56 11 AM