search

metanorma / metanorma-docker

Docker container for running the Metanorma toolchain
https://www.metanorma.com
5 stars 3 forks source link

#133 Upgrade ruby version to 3.1 #135

Closed CAMOBAP closed 2 years ago

CAMOBAP commented 2 years ago
ronaldtse commented 2 years ago

@CAMOBAP the builds are failing on compilation of the “rice” gem at version 3.0.0. However, we should have already upgraded it to 4.0.0 for expressir. Can you help check? Thanks.

ronaldtse commented 2 years ago

Thank you @CAMOBAP !

ronaldtse commented 2 years ago

BTW will the merging of this one trigger metanorma-docker-private?

CAMOBAP commented 2 years ago

BTW will the merging of this one trigger metanorma-docker-private?

Not yet unfortunately I think how to simplify maintenance of them

Probably I will move nist image back to this repo, I still think how to make it simplier

ronaldtse commented 2 years ago

But can we have private container in a public repo? Or they are separate?

CAMOBAP commented 2 years ago

But can we have a private container in a public repo? Or they are separate?

As far as I understand yes, according to the documentation: during the first push, the package "inherit" visibility from the repository, so now we can do the push from other place

ronaldtse commented 2 years ago

I see. I do remember that on GH Docker containers have a separate access control page, so maybe we don’t need a separate repository. However, we may not want the public to see even the names of the private containers.

CAMOBAP commented 2 years ago

I see. I do remember that on GH Docker containers have a separate access control page, so maybe we don’t need a separate repository. However, we may not want the public to see even the names of the private containers.

Good point

In this case, I will update metanorma-docker-private to maximally reuse code from metanorma-docker (Dockerfiles, scripts), and we will keep there any further private images

I will do this in the scope of:

ronaldtse commented 2 years ago

Thank you @CAMOBAP !