(URGENT) Broken docker images when running GHA due to pngcheck

metanorma / metanorma-docker

Docker container for running the Metanorma toolchain

https://www.metanorma.com

5 stars 3 forks source link

(URGENT) Broken docker images when running GHA due to pngcheck #164

Closed ronaldtse closed 1 year ago

ronaldtse commented 1 year ago

Example: https://github.com/metanorma/iso-10303-2/actions/runs/3059351763/jobs/4936626413

When the docker image was built, pngcheck 0.2.5 was used but it was not compilable on Linux without the correct tooling. pngcheck 0.2.6 fixed this but this image doesn't include it and does not work.

We need to urgently re-publish the Metanorma Docker image for this particular metanorma-cli version.

ronaldtse commented 1 year ago

This is the workaround we had to do for it https://github.com/metanorma/SWF-Corpus_and_IEEEP2874-D2/pull/9

CAMOBAP commented 1 year ago

Restarted pipeline for v1.6.1 it should bundle install to include latest pngcheck gem

I will doublecheck in logs

Update:

https://github.com/metanorma/metanorma-docker/actions/runs/3020149427/jobs/4944655969#step:8:3002 - metanorma-ruby, pngcheck with correct version
https://github.com/metanorma/metanorma-docker/actions/runs/3020149427/jobs/4944656048#step:8:1892 - metanorma-ubuntu pngcheck with correct version
https://github.com/metanorma/metanorma-docker/actions/runs/3020149427/jobs/4944656122 - metanorma-alpine uses cache, it should be invalidated on Gemfile changes, will prepare PR

CAMOBAP commented 1 year ago

caching temporally disabled to release updated docker images

CAMOBAP commented 1 year ago

New docker image released with updated pngcheck.

To resurrect caching, maybe we can do bundle install before docker build and them COPY Gemfile.lock to image so we will be able to reuse previous cached layers and bundle install will always be up-to-date

@ronaldtse @abunashir @opoudjis any thoughts on this?

ronaldtse commented 1 year ago

@CAMOBAP that's perfect. Thank you!