search

metanorma / metanorma-docker

Docker container for running the Metanorma toolchain
https://www.metanorma.com
5 stars 3 forks source link

Lock bundler to a specific version #47

Closed abunashir closed 4 years ago

abunashir commented 4 years ago

There were some changes in bundler 2.0.2 to 2.1.0 and official ruby images that were causing issues with ruby gems executables. This is what causes our build process to fail.

There are some fixes coming up in ruby 2.7 image and next bundler release, but for now, let's lock the bundler version to 2.0.0.

Fixes: https://github.com/metanorma/metanorma-docker/issues/46 Details: https://github.com/bundler/bundler/issues/7494

ronaldtse commented 4 years ago

@CAMOBAP795 do we need to trigger a release?

CAMOBAP commented 4 years ago

@ronaldtse push to master will update the image forlatest tag

If we need some x.y.z we need to git tag x.y.z & git push --tags

ronaldtse commented 4 years ago

Right — if the current tagged docker image works, we don’t need to tag new one. But if not, we should re-tag and build new one. (Latest and newest tagged container should always be identical)

CAMOBAP commented 4 years ago

@ronaldtse published ~20 min ago https://hub.docker.com/layers/metanorma/mn/latest/images/sha256-952b620b9dfd832d0876a15e06b89c3aa6c2b1caa6043186893701db6b31b286

ronaldtse commented 4 years ago

Thanks @CAMOBAP795 !