metanorma / metanorma-docker

Docker container for running the Metanorma toolchain
https://www.metanorma.com
5 stars 3 forks source link

docker failing to install pip, so cannot update #49

Closed opoudjis closed 4 years ago

ronaldtse commented 4 years ago

ping @CAMOBAP795

ronaldtse commented 4 years ago

This might be related to the deprecation of Python 2, might need to do this first:

sudo apt-get install -y python3-pip
CAMOBAP commented 4 years ago

Looks like fixed by @ronaldtse already https://github.com/metanorma/metanorma-docker/commit/a9c7cb4c73dca0526fc7c1a9e85bd15e3e0ece20

ronaldtse commented 4 years ago

This is fixed in a9c7cb4

opoudjis commented 4 years ago

Issue has reemerged: https://github.com/metanorma/metanorma-docker/runs/417185859?check_suite_focus=true

CAMOBAP commented 4 years ago

@opoudjis looks like you did tag on https://github.com/metanorma/metanorma-docker/commit/84c8a9fc72d4b889734f1a8d441d291cba0f0f9a some outdated commit, because if you will check Dockerfile.in for it, there is no python-pip3 installation

I will retag it

ronaldtse commented 4 years ago

@CAMOBAP795 is this fixed now?

CAMOBAP commented 4 years ago

@ronaldtse yes, in fact, this was fixed by you

For some reason, Github Actions didn't start on git tag -f ..., so I just pushed another tag

CAMOBAP commented 4 years ago

I forgot that tag must correlate with metarnorma-cli, should be fixed now

CAMOBAP commented 4 years ago

https://github.community/t5/GitHub-Actions/How-to-trigger-GitHub-Actions-on-retag/m-p/44823

opoudjis commented 4 years ago

So Alex, what should I be doing differently?

<update metanorma-cli version number in> metanorma/metanorma-docker//Makefile 
git commit
git push
git tag <metanorma-cli version number>
git push --tags
ronaldtse commented 4 years ago

Closing this.