search

metanorma / metanorma-docker

Docker container for running the Metanorma toolchain
https://www.metanorma.com
5 stars 3 forks source link

On every metanorma-docker release, re-deploy mn-samples-* repos using the latest released docker container #90

Closed opoudjis closed 4 years ago

opoudjis commented 4 years ago

Currently, when the docker-mn.yml workflow is triggered, the samples directories are tested.

However, they need to be compiled to gh-pages, not just tested: the changes in rendering with each release, for each samples directory, need to be visible externally.

Right now, because I was assuming this was already happening, I am not manually triggering samples compilation. And it is not practical for me to do so: docker takes a half hour to compile, and I usually go to bed right after finishing release.

opoudjis commented 4 years ago

@ronaldtse Please confirm this is needed

ronaldtse commented 4 years ago

They are already automatically done. e.g. ITU http://metanorma.github.io/mn-samples-itu

ronaldtse commented 4 years ago

Specifically in mn-samples-itu , it is this line that deploys it: https://github.com/metanorma/mn-samples-itu/blob/399ae4abe680aaea9e9d84df5cf73816fd5e1077/.github/workflows/docker.yml#L53

Closing now.

CAMOBAP commented 4 years ago

I think @opoudjis means that make sense to trigger gh-pages deploy on release too.

Currently we as part of metanorma-docker flow we do testing by cloning samples repositories and run build with docker. With this approach gh-pages stays untouched, because we doing this 'locally'

It sounds reasonable to me to trigger samples repos once new docker image pushed to docker hub

@ronaldtse how do you think?

ronaldtse commented 4 years ago

I misunderstood what @opoudjis meant (well, it was poorly described).

I agree with @CAMOBAP that once the released docker image is pushed to docker hub, we can trigger a re-deploy for all mn-sample-* repos.

@CAMOBAP I also want to be sure that a test release of metanorma-docker will not trigger the mn-samples-* repos (the last thing we want is to have those deployed repos break!)

CAMOBAP commented 4 years ago

@ronaldtse to be on the same page by "test release of metanorma-docker" you mean metanorma/mn updates right?

ronaldtse commented 4 years ago

@CAMOBAP correct, I was unclear there.

CAMOBAP commented 4 years ago

@ronaldtse @opoudjis https://github.com/metanorma/metanorma-docker/pull/91 - done

I was wrong, previously we had this logic https://github.com/metanorma/metanorma-docker/blob/master/.github/workflows/docker-mn.yml#L36-L4

But it triggered build for any push to master, now I have restricted it to release only

ronaldtse commented 4 years ago

Thanks @CAMOBAP !

CAMOBAP commented 4 years ago

Done