Compilation fails when missing mandatory attributes

metanorma / metanorma-gb

Metanorma processor for GB: write Chinese Standards using GbDoc

BSD 2-Clause "Simplified" License

2 stars 3 forks source link

Compilation fails when missing mandatory attributes #13

Closed ronaldtse closed 6 years ago

ronaldtse commented 6 years ago

Right now if I miss :standard-class: it says:

TypeError: no implicit conversion of nil into String
  /Users/user1/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/asciidoctor-gb-07a3606bf240/lib/asciidoctor/gb/metadata.rb:130:in `gsub'

Which is quite ugly. It should really provide an error with a hint to the user what needs to be filled in?

opoudjis commented 6 years ago

I've got a ticket to validate prefixes; I will make the document default to GB national, but I will issue a warning if it does.