metanorma / metanorma-ietf

Metanorma processor for IETF documents
BSD 2-Clause "Simplified" License
6 stars 5 forks source link

metanorma adds an <aside> element to rfc xml for NOTE: #182

Closed douglm closed 1 year ago

douglm commented 1 year ago

Trying to build (locally on my mac) the spec here:

https://github.com/CalConnect/PUBLIC_DRAFTS/tree/master/ical-tasks

Failed with the messages:

sources/draft-ietf-calext-ical-tasks.rfc.xml(344): Error: Element dd has extra content: aside, at /rfc/middle/section[10]/section[4]/dl/dd[1]/aside
sources/draft-ietf-calext-ical-tasks.rfc.xml(9): Error: Invalid document before running preptool.
Unable to complete processing sources/draft-ietf-calext-ical-tasks.rfc.xml
sources/draft-ietf-calext-ical-tasks.rfc.xml(344): Error: Element dd has extra content: aside, at /rfc/middle/section[10]/section[4]/dl/dd[1]/aside
sources/draft-ietf-calext-ical-tasks.rfc.xml(9): Error: Invalid document before running preptool.
Unable to complete processing sources/draft-ietf-calext-ical-tasks.rfc.xml

There is an <aside> element at line 344 - it seems every NOTE: generates an <aside> element

Tried a brew upgrade metanorma

and it told me

 metanorma/metanorma/metanorma 1.4.17.20211007_1 already installed

Edited the xml and removed all the <aside> elements. xml2rfc accepted that.

ronaldtse commented 1 year ago

Thank you @douglm for raising this!

@opoudjis could you help review the aside situation?

@CAMOBAP could you please help check the issue with Homebrew?

douglm commented 1 year ago

I've made a few updates to the draft and reran and the problem seems to have disappeared. I did remove one of the NOTEs

On 2/19/23 23:35, Ronald Tse wrote:

Thank you @douglm https://github.com/douglm for raising this!

@opoudjis https://github.com/opoudjis could you help review the |aside| situation?

@CAMOBAP https://github.com/CAMOBAP could you please help check the issue with Homebrew?

— Reply to this email directly, view it on GitHub https://github.com/metanorma/metanorma-ietf/issues/182#issuecomment-1436318785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW2MBWVKUEOJ6WPYI3V5ATWYLYCPANCNFSM6AAAAAAVASDDHI. You are receiving this because you were mentioned.Message ID: @.***>

CAMOBAP commented 1 year ago

@ronaldtse @douglm metanorma version looks really old, I investigating right now why brew upgrade doesn't work

As workaround I can suggest try brew uninstall metanorma && brew install metanorma/metanorma/metanorma

Update

https://github.com/metanorma/homebrew-metanorma/issues/84#issuecomment-1436968179

It looks like auto-update is broken for our formula, it hard to say why this may happens. there are possible workarounds for this:

  • brew tap --force-auto-update metanorma/metanorma && brew upgrade metanorma or
  • brew update && brew upgrade metanorma or
  • brew uninstall metanorma && brew install metanorma/metanorma/metanorma
opoudjis commented 1 year ago

This is a XML RFC v3 schema restriction that I cannot say I welcome.

opoudjis commented 1 year ago

In fact, I already have code moving asides to after blocks they are embedded with; it was only applied to t figure table. I'm going to generalise that to everything but section.