metanorma / metanorma-iso

Metanorma processor for ISO standards
BSD 2-Clause "Simplified" License
14 stars 5 forks source link

Support localized strings for 'Recommendation' document type (old ISO documents) #1097

Closed Intelligent2013 closed 8 months ago

Intelligent2013 commented 8 months ago

Source issue: https://github.com/metanorma/metanorma-iso/issues/1089

Currently, for adoc:

:doctype: recommendation

the Presentation XML looks so:

        <ext>
            <doctype>recommendation</doctype>

Expected results:

        <ext>
            <doctype language="">recommendation</doctype>
            <doctype language="en">ISO Recommendation</doctype>
        <ext>
            <doctype language="">recommendation</doctype>
            <doctype language="fr">Recommandation ISO</doctype>

Note: for 'ru' I can't find the old document.

opoudjis commented 8 months ago

Clearly the doctype label will be either Recommendation or ISO Recommendation depending on the rendering label. I'll switch it accordingly.

opoudjis commented 8 months ago

The document-scheme values are going to be:

I will make the doctype be ISO Recommendation only in the 1951 scheme.

opoudjis commented 8 months ago

Actually, let me back up: Recommendation is an obsolete document type. So it's fine to associate "recommendation" as a document type with ISO Recommendation.

opoudjis commented 8 months ago
:doctype: recommendation

now consistently gives:

<doctype language="">recommendation</doctype><doctype language="en">ISO Recommendation</doctype>
Intelligent2013 commented 8 months ago

@opoudjis thanks!