metanorma / metanorma-iso

Metanorma processor for ISO standards
BSD 2-Clause "Simplified" License
13 stars 5 forks source link

Validate 2024 PDF layout using production standard #1134

Closed ronaldtse closed 5 months ago

ronaldtse commented 5 months ago

We need to validate our implementation of the 2024 layout against a production standard:

This is a private copy.

Intelligent2013 commented 5 months ago

Our implementation of the 2024 layout looks differently:

Our PDF layout was updated in https://github.com/metanorma/metanorma-iso/issues/1079 based on the provided PDF example 2024-iso-new-pdf-layout.pdf "Sample of layout for an International Standard (cover page, back page and internal centered layout)".

@ronaldtse to further actions I have to know exactly - what is the correct PDF - in this issue or in https://github.com/metanorma/metanorma-iso/issues/1079?

Note: the PDF from the initial posts opens in the Chrome browser only. Adobe Acrobat opens it and closes immediately, also Foxit Reader and PDF-XChange Viewer. So I have to repair it somehow.

ronaldtse commented 5 months ago

Adobe Acrobat opens it and closes immediately

I'm seeing the same issue too. I can open it in macOS Preview however.

It is very likely that their "design spec" and implemented production PDF are slightly different.

Intelligent2013 commented 5 months ago

The last link points to https://www.iso.org/.

From metanorma-iso gem boilerplate.adoc:

[[boilerplate-address]]
[align=left]
ISO copyright office +
CP 401 • Ch. de Blandonnet 8 +
CH-1214 Vernier, Geneva +
Phone: +41 22 749 01 11 +
Email: copyright@iso.org +
Website: www.iso.org

Presentation XML:

    <p id="boilerplate-address" align="left">ISO copyright office<br/>
CP 401 • Ch. de Blandonnet 8<br/>
CH-1214 Vernier, Geneva<br/>
Phone: +41 22 749 01 11<br/>
Email: <link target="mailto:copyright@iso.org"/>
        <br/>
Website: www.iso.org</p>
                ...
        </copyright-statement>

copyright@iso.org automatically converts to <link target="mailto:copyright@iso.org"/>, but www.iso.org doesn't. I need update boilerplate.adoc

Intelligent2013 commented 5 months ago

To check the whole document I'll encode it in adoc.

Intelligent2013 commented 5 months ago

The rendered PDF is correct. From https://www.iso.org/sites/directives/current/part2/index.xhtml#_idTextAnchor340:

24.3 Numbering and subdivision Within a given clause or subclause, notes shall be numbered sequentially. The numbering restarts at each new subdivision. A single note in a subdivision shall not be numbered.

From https://www.metanorma.org/author/topics/blocks/lists/#general-2: image

Intelligent2013 commented 5 months ago

There is the identical entry in the Normative references and Bibliography: image

image

therefore different identifiers should be used in the adoc:

[bibliography]
== Normative references

* [[[ISO19103,ISO 19103]]], _Geographic information -- Conceptual schema language_
...

[bibliography]
== Bibliography

* [[[ISO19103bib,ISO 19103]]], _Geographic information -- Conceptual schema language_
,..
Intelligent2013 commented 5 months ago
Intelligent2013 commented 5 months ago

Presentation XML contains en dash:

</xref>, modified
 – Note 1 to entry removed.]</termsource>
Intelligent2013 commented 5 months ago
Intelligent2013 commented 5 months ago

Note: I don't know how to achieve it.

Intelligent2013 commented 5 months ago
Intelligent2013 commented 5 months ago
ronaldtse commented 5 months ago

@Intelligent2013 can you help file issues for @opoudjis for those he needs to fix? Thanks.

Intelligent2013 commented 5 months ago
Intelligent2013 commented 5 months ago
Intelligent2013 commented 5 months ago

Adoc markup:

<<ref10>>,<<ref15>>
Intelligent2013 commented 5 months ago
  • [x] text with indent
    • rendered PDF: image
    • production PDF: image

This issue can be solved via css: [css text-indent:7mm]#*1) CoreClassConformant*#. Rendered PDF: image

Intelligent2013 commented 5 months ago
Intelligent2013 commented 5 months ago

ISO XSLT updated for PDF layout 2024. Only one issue remains: https://github.com/metanorma/metanorma-iso/issues/1141 On hold.

Intelligent2013 commented 5 months ago

Done.