search

metanorma / metanorma-plugin-glossarist

Glossarist plugin for Metanorma
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Lock Glossarist to model V1 #22

Closed HassanAkbar closed 1 year ago

HassanAkbar commented 1 year ago

Current version of metanorma-plugin-glossarist will not work with Glossarist model v2 so locking it to V1 until the code is updated.

HassanAkbar commented 1 year ago

@ronaldtse Can you elaborate on this? I am not sure if I understand this correctly. Do you mean that we should use different versions of glossarist for different models as specified by the user? Is this correct?

If yes, then I’ll have to look into it because I don’t know how to add multiple gem versions based on a condition. So, this might take some time.

ronaldtse commented 1 year ago

I think the glossarist gem should support both v1 and v2 models and datasets.

We can use a separate adapter class for older versions for import and export.

HassanAkbar commented 1 year ago

@ronaldtse I removed the support for Glossarist Model V1 because of our discussion https://github.com/geolexica/jekyll-geolexica/issues/14#issuecomment-1778883420,

But if it is needed I can add an adapter class to handle that as well.

ronaldtse commented 1 year ago

@HassanAkbar if there are no datasets that use v1 anymore, there is no need to support it.

HassanAkbar commented 1 year ago

@ronaldtse isotc204-glossary and osgeo-glossary both are in V1 format.

I'll write an adapter to read from the V1 format. But I think we do not need a writer for V1 because the new output should always be in V2, this will also make moving concepts from V1 to V2 very easy we will have to read them and output them.

What do you suggest?

ronaldtse commented 1 year ago

I'll write an adapter to read from the V1 format. But I think we do not need a writer for V1 because the new output should always be in V2, this will also make moving concepts from V1 to V2 very easy we will have to read them and output them.

@HassanAkbar I agree with the approach. Thanks!

HassanAkbar commented 1 year ago

@ronaldtse Closing this PR because now glossarist version 2.0.1 is backward compatible with glossarist model V1 so there is no need to lock it to V1.