Open opoudjis opened 1 month ago
And something has clearly gone colossally wrong with the bibliographic anchor:
ISO 6709:2008, 4.1, modified – The preferred term is "measurement accuracy" rather than "accuracy" and Notes 1 to 3 have been added.
That should have been marked up as follows; recall that clause references are marked separately from the work, https://github.com/metanorma/metanorma-plugin-glossarist/issues/29, and that modifications of definitions are parsed as text following the source reference (minus the "modified —" introductory text, which Metanorma adds automatically):
[.source]
<<ISO_6709_2008,clause=4.1>>, The preferred term is "measurement accuracy" rather than "accuracy" and Notes 1 to 3 have been added.
From https://github.com/metanorma/metanorma/issues/75, TC 211
This may be a data source issue, but: Metanorma is quite specific about what goes into the fetch code of a bibliographic reference. If it is not a standard identifier, then a full bibliographic reference needs to be given, following one of the conventions in https://www.metanorma.org/author/topics/sections/bibliography/ . The preferred format is https://www.metanorma.org/author/topics/sections/bibliography/#annotated-spans . But that will end up a separate ticket.
In addition, the fetch code needs to be well-formed; that means no
]
(since]
is a delimiter in the bibliographic reference), no parenthetic comments (ISO/IEC TR 14252(Adapted from)
is not a bibliographic reference, it is a bibliographic reference plus commentary, and it should have been fixed in the YAML), and no discursive chatter.Metanorma is finding something objectionable in all of the following:
Of these:
19161-1:2020
is presumably meant to beISO 19161-1:2020
DCAT[8]
should not be an anchor,[
and]
are illegal characters in XML anchors; this should beDCAT_8_
(and in fact, I strongly suspect the "8" is intended as a bibliographic tag in a numbered bibliography). Metanorma::Utils.to_ncname() https://github.com/metanorma/metanorma-utils/blob/8b21b4640c09b11774db754f926a3a1d236bdd50/lib/utils/xml.rb#L30 is the function Metanorma uses to sanitise identifiers for use as XML anchors.Palmer__amp;_Dodge
, using Metanorma::Utils.to_ncname(), and the "derived from" note should instead be added to the source, as follows: https://www.metanorma.org/author/topics/sections/concepts/#modifying-sourced-concepts https://www.metanorma.org/author/topics/sections/concepts/#complex-source-attributes(for just ", modified")
(will end up the same)
(I don't recommend that, but it allows an underspecified relation. I recommend "modified", and that is what ISO expects to see.)
(Of course, it would be far preferable if the "modified/adapted" were indicated as status attributes on the source in the YAML.
This may well be forcing a bunch of QA on the termbase. At the risk of callousness, that's not my problem, that's the data provider's. Bibliographic entries like "Adapted from Albota 2002" are simply malformed, and we should not expect them to provide a coherent bibliographic reference. (After all, the expectation is that it links to "Albota 2002" somehow.)