search

metanorma / metanorma-plugin-lutaml

Metanorma plugin: access LutaML objects from within a Metanorma document
BSD 2-Clause "Simplified" License
1 stars 1 forks source link

feat: (WIP) use coradoc #112

Closed ronaldtse closed 5 months ago

ronaldtse commented 5 months ago

But all relevant specs are failing. All we use is Coradoc::ReverseAdoc.convert

opoudjis commented 5 months ago

Until this issue is resolved, I am forced to use the older version of reverse_adoc, as I have been the past two months.

The deprecation notice telling every user to migrate to coradoc SHOULD NOT HAVE BEEN ISSUED until this was resolved. I was very clear in https://github.com/metanorma/reverse_adoc/issues/93 that the refactoring of reverse_adoc is impacting the existing Metanorma stack, and that this issue needed to be addressed urgently.

As it stands, our end users are now being exposed to a misleading deprecation notice, and they're going to ask questions of me for it, not whoever is working on coradoc.

This is production software, and it needs a production software approach to it. If coradoc is not production-ready, and reverse_adoc is used in the production stack, then issuing a deprecation notice is premature and irresponsible.

ronaldtse commented 5 months ago

The error is actually from not correctly specifying:

require 'coradoc'
require 'coradoc/reverse_adoc'