search

metanorma / metanorma-plugin-lutaml

Metanorma plugin: access LutaML objects from within a Metanorma document
BSD 2-Clause "Simplified" License
1 stars 1 forks source link

spec breaking on invalid URIs #117

Closed opoudjis closed 2 months ago

opoudjis commented 3 months ago

https://github.com/metanorma/metanorma-plugin-lutaml/actions/runs/9640683586/job/26584966393

This is now also breaking metanorma-standoc, since it has the same test.

Gems MUST NOT BE RELEASED if they are breaking testing. This is now breaking the Metanorma stack, which is a downstream consumer of this gem as infrastructure. Testing MUST BE TAKEN SERIOUSLY in Metanorma infrastructure development.

opoudjis commented 3 months ago

@CAMOBAP this has been breaking standoc on GHA for days, you should be being notified on it.

The advice from @ronaldtse is that I should comment out the relevant standoc tests temporarily while this is being looked into.

Standoc integration testing is essential, because I cannot trust downstream gems not to fall over. This gem has now fallen over, and I do not have any reason to trust that the new lutaml/xmi gem is working until I can be provided a test which does work.

There will be NO METANORMA RELEASE until this issue is resolved. I am going on holiday on Saturday, where I intend not to think about failures to take downstream dependencies and pre-release testing seriously, for the next week. When I come back on July 7, I expect this to be addressed by me being provided with new tests, to replace the tests in metanorma-plugin-lutaml duplicated in metanorma-standoc:

rspec ./spec/metanorma/macros_spec.rb:1213 # Metanorma::Standoc lutaml_figure macro correctly renders input
rspec ./spec/metanorma/macros_spec.rb:1287 # Metanorma::Standoc lutaml_uml_datamodel_description macro correctly renders input

I do not get the feeling that this is being taken seriously as it needs to be. Again: Gems MUST. NOT. BE. RELEASED if they are breaking testing. By anyone. No matter how senior.

CAMOBAP commented 3 months ago

@CAMOBAP this has been breaking standoc on GHA for days, you should be being notified on it.

At the moment I just added workflows to run, @ronaldtse could you please add me to mailing lists for isodoc, metanorma-iso and metanorma-standoc so I get all notifications related to GHA

opoudjis commented 3 months ago

@CAMOBAP this has been breaking standoc on GHA for days, you should be being notified on it.

At the moment I just added workflows to run, @ronaldtse could you please add me to mailing lists for isodoc, metanorma-iso and metanorma-standoc so I get all notifications related to GHA

I haven't been getting notifications, FWIW, but the integration job ran on standoc for the first time today (after I pushed the test disable).

opoudjis commented 2 months ago

@ronaldtse @kwkwan Progress on this, please. This is a broken test on Metanorma infrastructure, it cannot just be allowed to lapse. https://github.com/metanorma/metanorma-plugin-lutaml/commit/d89e43d375e1f6215c9eb2d9c1359e275bee4ffd has not addressed the issue.

kwkwan commented 2 months ago

@opoudjis Some tests are rewriting to reflect the changes in xmi.

ronaldtse commented 2 months ago

The relevant task is here: