Utilize common license agreement, warning and preface notes

metanorma / mn-samples-ogc

Metanorma for OGC sample documents

1 stars 2 forks source link

Utilize common license agreement, warning and preface notes #73

Closed ronaldtse closed 4 years ago

ronaldtse commented 4 years ago

When these tasks are completed:

metanorma/metanorma-ogc#116
metanorma/metanorma-ogc#117
metanorma/metanorma-ogc#118

All samples (esp 08-062r7 as described in #22 and metanorma/metanorma-ogc#91) should be updated to utilize the common text.

manuelfuenmayor commented 4 years ago

@ronaldtse , I have checked the OGC outputs and they all meet with the specifications given in https://github.com/metanorma/metanorma-ogc/issues/91

Just two comments to make:

Several docs (10-091r3, 10-100r3, 14-065r2, among others) contain duplicated Preface notes: one generated automatically, and other included by the user in the Preface area. I guess we should remove this last one, right? (I could push PR for that)
The warning message established for Best Practice differs in a word from the description given.

In https://github.com/metanorma/metanorma-ogc/issues/91: "This document defines an OGC Best Practice on a particular technology..." While, in the outputs: "This document defines an OGC Best Practices on a particular technology..."

(Maybe not a big deal?)

Thanks!

ronaldtse commented 4 years ago

Several docs (10-091r3, 10-100r3, 14-065r2, among others) contain duplicated Preface notes: one generated automatically, and other included by the user in the Preface area. I guess we should remove this last one, right? (I could push PR for that)

Yes please!

"This document defines an OGC Best Practice on a particular technology..." While, in the outputs: "This document defines an OGC Best Practices on a particular technology..."

It should be the first ("This document defines an OGC Best Practice on a particular technology...") since the latter one has wrong grammar.

Thanks!

ronaldtse commented 4 years ago

Is the warning message mistake generated automatically or manually? If automatically, it should be filed at metanorma-ogc. Thanks!

manuelfuenmayor commented 4 years ago

Is the warning message mistake generated automatically or manually? If automatically, it should be filed at metanorma-ogc. Thanks!

Automatically, warning-capture

Ok!

manuelfuenmayor commented 4 years ago

Is the warning message mistake generated automatically or manually? If automatically, it should be filed at metanorma-ogc. Thanks!

Ticket opened here: https://github.com/metanorma/metanorma-ogc/issues/131

manuelfuenmayor commented 4 years ago

@ronaldtse , @opoudjis has already solved the problem of the warning message. I think all is good now regarding this issue.

manuelfuenmayor commented 4 years ago

This issue is solved. Closing.