search

metanorma / mn-samples-plateau

Project PLATEAU by MLIT: Japanese Ministry of Land, Infrastructure, Transport and Tourism (国土交通省)
https://www.mlit.go.jp/plateau/
0 stars 0 forks source link

(Urgent) All builds failing due to `relaton-plateau` crash at end of site generate #166

Open ronaldtse opened 3 weeks ago

ronaldtse commented 3 weeks ago

@andrew2net please help investigate.

Reported by @ReesePlews

ronaldtse commented 3 weeks ago

The crash is seen in all builds:

andrew2net commented 3 weeks ago

The crash is seen in all builds:

This was fixed in relaton-plateau v1.19.3 https://github.com/relaton/relaton-plateau/issues/14 But the GHA still uses v1.19.2

andrew2net commented 3 weeks ago

BTW I got 2 issues when running the build locally:

ReesePlews commented 3 weeks ago

hello @andrew2net thank you for checking into this problem. is there an update or any other additional information I can provide to you?

But the GHA still uses v1.19.2

is the "GHA" the docker.yml file? i did not see any "version" information in that file. if an update will fix this problem, please consult with @ronaldtse and update it.

regarding your statement:

isodocgem wasn't installed previously on my comp and it's not in this repo's dependencies, the build fails until I installed the gem by hand

when i do a bundle update this is the isodoc version i get

Using isodoc 2.11.1 from https://github.com/metanorma/isodoc (at main@1d98089)

do you think this is correct or is a different version needed?

i also did a manual install of isodoc but the same version 2.11.1 was installed.

during that manual install of isodoc there was the following message at the end:

A new release of RubyGems is available: 3.5.9 → 3.5.18!
Run `gem update --system 3.5.18` to update your installation.

i dont think it makes a difference but i have updated RubyGems as instructed and it appears to be successfully updated.

thank you.

andrew2net commented 3 weeks ago

is the "GHA" the docker.yml file? i did not see any "version" information in that file. if an update will fix this problem, please consult with @ronaldtse and update it.

@ReesePlews The GHA is "GitHub Actions", which runs the build. The old version could be cached in GHA, but since a docker container is used it's more likely it's installed inside the container. You can see the version number in the log: https://github.com/metanorma/mn-samples-plateau/actions/runs/10562694995/job/29261234226#step:6:4457 So we need to ask whoever supports the container to rebuild it with updated relaton-plateau version.

ronaldtse commented 3 weeks ago

This will be fixed once @opoudjis releases the new Metanorma-cli which will trigger the new build if the container.

ReesePlews commented 3 weeks ago

hi @ronaldtse thanks for the update. and that build will merge in all of the recent commits and PRs to the "main" branch?

ronaldtse commented 3 weeks ago

@ReesePlews no, it will just fix the build errors.

opoudjis commented 3 weeks ago

Fixing code and merging PRs to code is my responsibility, and that happens every two weeks.

Fixing documents and merging PRs is an editorial responsibility, and is a separate activity.

ronaldtse commented 2 weeks ago

@CAMOBAP @opoudjis can we please get this issue addressed? Every PR is breaking, the build is breaking, and this is just unacceptable to the client.

ronaldtse commented 2 weeks ago

The client wants to compile the document themselves. It is not currently possible. We need to fix this instead of telling the client "wait for 2 weeks and pray that it works".

ronaldtse commented 2 weeks ago

The client is wondering why it takes 2 weeks for the document to be fixed.

ronaldtse commented 2 weeks ago

@CAMOBAP This repository contains a Gemfile using an isodoc git gem, which is not released.

How can we make the Docker container work with this?

Located at: