metanorma / mn-samples-plateau

Project PLATEAU by MLIT: Japanese Ministry of Land, Infrastructure, Transport and Tourism (国土交通省)
https://www.mlit.go.jp/plateau/
1 stars 0 forks source link

Document 01 & 02: Add underline where needed #72

Closed anermina closed 2 months ago

anermina commented 3 months ago

Procedure: no underlines Same as above → thought to be an ADOC amendment Pattern C​

Document 01: image

Document 02: image

5th and 49th comment from Plateau team

ronaldtse commented 3 months ago

These are indeed missing. We actually need a way to encode these properly.

opoudjis commented 3 months ago

https://www.metanorma.org/author/topics/inline_markup/text_formatting/#underline

[underline]#text#

ronaldtse commented 3 months ago

Caution needs to be taken here.

Type 1: really textual content missing underlines (random underlines in text). => please fix in markup.

Type 2: The ones that say "留意事項" always have their first line underlined. However, this is a presentational issue in the document model. Please do not manually underline any of these.

Screenshot 2024-07-16 at 1 38 14 PM

Thanks!

ReesePlews commented 3 months ago

if these type of provisions are presented in another, more uniform/highlighted style, i am wondering if these type of underlines are really necessary or not. feedback from the client will help to clarify this.

ronaldtse commented 3 months ago

The bleeding of the underline style for links to after the HTTP link has been fixed in #115.

anermina commented 2 months ago

Type 1: really textual content missing underlines (random underlines in text). => please fix in markup.

I think this part is still not fixed. @ronaldtse , could you please confirm that this still needs to be done? Thank you.

manuelfuenmayor commented 2 months ago

I'm taking care of that...

Done.