metanorma / mn-samples-plateau

Project PLATEAU by MLIT: Japanese Ministry of Land, Infrastructure, Transport and Tourism (国土交通省)
https://www.mlit.go.jp/plateau/
1 stars 0 forks source link

Document 02: Annotations are missing #73

Closed anermina closed 3 months ago

anermina commented 3 months ago

Procedure: annotations are missing, many similar sections below → thought to be ADOC modifications Pattern C​

image

image

51st and 52nd comment from Plateau team

ronaldtse commented 3 months ago

Some table captions are missing which we should fix. Most table captions are present though, so it's not a technical issue.

ronaldtse commented 3 months ago

PDF fixed:

Screenshot 2024-07-16 at 6 55 49 PM Screenshot 2024-07-16 at 6 56 14 PM

HTML missing legend: "表 2-16 — 作成制限施設の規則"

Screenshot 2024-07-16 at 6 56 36 PM

"表 K-1 — 都市計画決定情報モデルの記述に使用する地物型と空間属性"

Screenshot 2024-07-16 at 6 57 09 PM
opoudjis commented 3 months ago

Plateau inherits table processing from JIS (at the moment), so this is an omission in JIS.

opoudjis commented 3 months ago

isodoc natively expects to see dl at this point for keys. But JIS preemptively has converted dl to paragraphs already. I'm going to respect that, at least for now, and allow paragraphs in JIS to take the role of definition keys for tables. (I'd already dealt with figures.)

opoudjis commented 3 months ago

Screenshot 2024-07-16 at 23 41 47

To see this, pull metanorma-jis

ronaldtse commented 3 months ago

isodoc natively expects to see dl at this point for keys. But JIS preemptively has converted dl to paragraphs already. I'm going to respect that, at least for now, and allow paragraphs in JIS to take the role of definition keys for tables. (I'd already dealt with figures.)

Thanks and it looks good. I wonder if this is the time to just align internal code across flavors because table legends are now commonly available across flavors.

opoudjis commented 3 months ago

I don't know what you mean. The code is consistently dl for table keys, across Metanorma; the problem was that JIS uniquely treats dl as paragraphs, and therefore it couldn't find the dl any more in the Presentation XML.

ronaldtse commented 3 months ago

the problem was that JIS uniquely treats dl as paragraphs, and therefore it couldn't find the dl any more in the Presentation XML

I was wondering why JIS treats dl differently, and if a unified approach is better.

opoudjis commented 2 months ago

(Thought I'd answered this.)

JIS renders dl as tables consistently, and I'd made the decision to do that in Presentation XML and not just HTML, as I had done in ISO. I now think that was a mistake, since dl's are presupposed in HTML postprocessing inherited from Metanorma, but you can see why it'd be an open question where to handle it: both HTML and Presentation XML in JIS inherit from ISO, and one or the other is going to look different.