Make mnconvert work - Githubissues

metanorma / mnconvert-ruby

Ruby gem wrapper for mnconvert

2 stars 0 forks source link

Closed ronaldtse closed 3 years ago

ronaldtse commented 3 years ago

CAMOBAP commented 3 years ago

@ronaldtse @Intelligent2013 as far as I see this task almost complete, I see several points to fix:

Let me know if I missed something?

ronaldtse commented 3 years ago

Sounds good, thanks! mnconvert is at version 1.8.0 so this matches.

Intelligent2013 commented 3 years ago

Everything looks ok.

CAMOBAP commented 3 years ago

CAMOBAP commented 3 years ago

I didn't prepare PRs just pushed directly to main and added tests from mn2sts and sts2mn and they work

@ronaldtse @Intelligent2013 I think we are ready for release, manually this time

CAMOBAP commented 3 years ago

@Intelligent2013 let me know if there are some release planned for mnconvert soon, we will able to test autorelease https://github.com/metanorma/mnconvert/pull/23

Intelligent2013 commented 3 years ago

@Intelligent2013 let me know if there are some release planned for mnconvert soon, we will able to test autorelease metanorma/mnconvert#23

let's wait some days. I'm writing documentation (conversion rules) for mnconvert, after that I'll return to fixing mnconvert's issues.

CAMOBAP commented 3 years ago

@Intelligent2013 to be on the same page, do we have some critical issues right now?

I'm asking because all tests are green, and probably I can do 1.8.0 release just to unblock @opoudjis for https://github.com/metanorma/metanorma-standoc/issues/492

@Intelligent2013 how do you think?

Intelligent2013 commented 3 years ago

@CAMOBAP ah ok, no problem. It can be released. There aren't any critical issue. Please do it.

CAMOBAP commented 3 years ago