search

metanorma / mnconvert-ruby

Ruby gem wrapper for mnconvert
2 stars 0 forks source link

Add spec/fixtures/rfc8650.xml back in to repo #11

Closed opoudjis closed 1 year ago

opoudjis commented 2 years ago

I can't run rspec on it. How is GitHub Actions able to work around this?

ronaldtse commented 2 years ago

Why are we running an RFC in mnconvert?

CAMOBAP commented 2 years ago

@opoudjis I'm able to run test locally, three is nothing hacky in workflow according to Rakefile it will be downloaded for regular bundle exec rake

Maybe you can share more details about the issue?

CAMOBAP commented 2 years ago

Why are we running an RFC in mnconvert?

As far as I remember it was in mn2pdf or mn2sts tests, so I moved it here, if it can be skipped I can remove this test

ronaldtse commented 2 years ago

mnconvert includes functionality that converts RFC XML into MN Adoc, perhaps it is trying to test that? If that's the case it is a valid test.

CAMOBAP commented 1 year ago

Tests for rfc8650 passed locally and on CI. spec/fixtures/rfc8650.xml installs with Rakefile