Fix failing specs - Githubissues

metanorma / niso-jats

Ruby library to work with NISO JATS files

0 stars 4 forks source link

Fix failing specs #18

Open Novtopro opened 3 weeks ago

Novtopro commented 3 weeks ago

Need to fix failing specs

Novtopro commented 3 weeks ago

@ronaldtse I don't think it's easy to fix the failing specs since it seems a lot of tags are missing, for example

CleanShot 2024-10-30 at 11 21 54@2x CleanShot 2024-10-30 at 11 23 14@2x

Left is input while right is output

ronaldtse commented 3 weeks ago

So there are two separate models to incorporate:

oasis:table The OASIS table format is developed by OASIS as the CALS model. It is also described at Wikipedia. We will need to write a new gem to handle the "table model". There is an XSD version here.
ali is the NISO Access and License Indicators (ALI) Schemas that is a very simple XML/JSON model. We should use a different library to handle this.

Novtopro commented 3 weeks ago

@ronaldtse So what's your plan regarding this kind of test failures? Be aware, I didn't inspect all the test failures, above is just an example. There might be other tags that are supported by the gem yet.

ronaldtse commented 3 weeks ago

@Novtopro I've just prepared the ali gem to assist with the 2nd issue.

We need to parse the oasis:table with a new library.

Novtopro commented 3 weeks ago

@ronaldtse How should I use the ali gem in this gem?

Novtopro commented 3 weeks ago

@ronaldtse Besides the ali, we also need

oasis:table
mml:math

Once they're ready and we got https://github.com/lutaml/lutaml-model/issues/138 fixed, all tests should pass.

ronaldtse commented 3 weeks ago

The oasis:table element can be handled with:

https://github.com/lutaml/oasis-etm/ even though this task needs to be done: https://github.com/lutaml/oasis-etm/issues/1

The mml:math element can be handled with:

Instead of implementing code for the oasis-etm and mml gems, please file issues there for things that you need, and help updating them with PRs if you need to.

What we are more interested is in cases like https://github.com/lutaml/oasis-etm/issues/1 which will require enhancements in lutaml-model.

We want to know how we can update lutaml-model to support the current use case where niso-jats integrates the oasis-etm, ali and mml gems (and make it simple to integrate them without re-implementing).