metanorma / ogc-citygml-xmi

OGC CityGML 3.0 document in MDA
2 stars 0 forks source link

PDF: Captions are placed above the figures #113

Closed anermina closed 3 years ago

anermina commented 3 years ago

continues https://github.com/metanorma/ogc-citygml-xmi/issues/104

Figure captions are shown above the figures in PDF and below them in HTML.

HTML: image

PDF: image

Intelligent2013 commented 3 years ago

OGC xslt was developed for https://github.com/metanorma/metanorma-ogc/issues/182 (https://github.com/metanorma/metanorma-ogc/files/5145021/OGC.Document.Design_v6.pdf)

In the reference PDF, figure's captions are shown above the figures: image

@ronaldtse should I make changes here?

ronaldtse commented 3 years ago

It seems that many style guides recommend table captions to be on top, figure captions to be at bottom. We may adopt that later. And this aligns with our HTML practice.

@Intelligent2013 could you please help move Figure captions to the bottom (but keep Table captions on the top)? Thanks!

Intelligent2013 commented 3 years ago

could you please help move Figure captions to the bottom (but keep Table captions on the top)? Thanks!

Done:

image

image

ronaldtse commented 3 years ago

@Intelligent2013 if we are centering the figures, we will have to center the captions as well. Thanks.

Intelligent2013 commented 3 years ago

@Intelligent2013 if we are centering the figures, we will have to center the captions as well. Thanks.

@ronaldtse yes, it was made so. Anywhere wrong rendering?

ronaldtse commented 3 years ago

The citygml logo you showed on top is now left aligned but true caption is centered. If we are moving the caption to center, let’s center the image too.

anermina commented 3 years ago

@ronaldtse This image has logo on the left and white space on the right. I think that is why it looks like figures aren't centered, but it is actually the original image itself that makes it look that way.

Intelligent2013 commented 3 years ago

image

ronaldtse commented 3 years ago

Oh Wow… I’m going to edit the doc since it looks strange…

ronaldtse commented 3 years ago

I've replaced the logo with a centered version. Closing.