search

metanorma / pubid-core

BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Name of pubid-core is incorrect and actually misleading #2

Closed ronaldtse closed 2 years ago

ronaldtse commented 2 years ago

This gem is intended to share code between the pubid-iso and pubid-iec implementations. It is NOT the core of any other PubID parsers. It should be called "pubid-isoiec" instead. Maybe we should just combine the pubid-iso and pubid-iec gems.

mico commented 2 years ago

This gem is intended to share code between the pubid-iso and pubid-iec implementations. It is NOT the core of any other PubID parsers. It should be called "pubid-isoiec" instead. Maybe we should just combine the pubid-iso and pubid-iec gems.

I'm going to use it everywhere, now it's applied only to pubid-iso and pubid-iec but I plan to apply it to all pubid-* implementation (pubid-nist, pubid-ieee). It should be easy for pubid-ieee, but could be a challenge for pubid-nist (quite different structure).

ronaldtse commented 2 years ago

OK, I was worried that the ISO and IEC pubid formats will be consolidated here and that won't work for organizations like IEEE or NIST.

As long as we are keeping SDO-independent data elements in this gem it's okay.